Skip to content

ci: 迁移到 ci-workflows 浮动 @v1(node24)#3

Merged
wisdommen merged 1 commit into
masterfrom
feature/node24-ci-v1-floating-tag
May 29, 2026
Merged

ci: 迁移到 ci-workflows 浮动 @v1(node24)#3
wisdommen merged 1 commit into
masterfrom
feature/node24-ci-v1-floating-tag

Conversation

@wisdommen
Copy link
Copy Markdown
Contributor

@wisdommen wisdommen commented May 29, 2026

把 maven-ci.yml 里调用 ci-workflows 的引用从 @v1.0.0 改成浮动的大版本 @v1

ci-workflows 那边已经把 checkout / setup-java / cache 三个 action 升到 node24 的 v5 线,并发了 v1.1.0 + 浮动 @v1。GitHub 6 月 16 号要把 runner 默认切到 node24,老的 @v1.0.0 还卡在 node20,会一直冒 deprecation 警告。

改成 @v1 之后,以后这些 action 再做安全升级,只要 ci-workflows 移动 @v1 就自动跟上了,不用每个模块再单独发 PR 改 tag。

needs-nms / mc-version / secrets 都没动,等 verify-nms 绿了就能合。

Summary by CodeRabbit

  • Chores
    • Updated CI/CD workflow configuration to reference an updated version of the shared build workflow, ensuring the build process uses current standards.

Review Change Stack

ci-workflows 已经把三个 actions 升到 node24 的 v5 版本并发了 v1.1.0
和浮动大版本 @v1。改成 @v1 之后以后的安全 re-pin 会自动跟上,不用
每次再发 PR 改 tag。

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 29, 2026

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

The Maven CI workflow version reference is updated from the pinned v1.0.0 tag to v1, allowing the workflow to automatically track the latest v1 release of the shared reusable ci-workflows repository without explicit version updates.

Changes

Workflow Configuration

Layer / File(s) Summary
Maven CI version reference update
.github/workflows/maven-ci.yml
The ci job's reusable workflow reference is updated from UltiKits/ci-workflows/.github/workflows/[email protected] to @v1.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰 A version tag hops from pinned to free,
v1.0.0 becomes just v1 with glee,
Now Maven flows with the latest release,
No manual bumps for eternal peace! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title is partially related to the changeset. It mentions migration to ci-workflows with @v1 floating tag and node24, which accurately reflects the main objective described in the PR objectives. However, the title is in Chinese and uses somewhat informal language ('浮动' meaning 'floating'). The title does convey the primary change but could be clearer for broader audiences.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/node24-ci-v1-floating-tag

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@wisdommen wisdommen merged commit 63ffb9f into master May 29, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant