Skip to content

feat: Add more options menu to live room with dpad menu key support #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

feat: Add more options menu to live room with dpad menu key support #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b3f0622
Initial plan
Copilot Dec 14, 2025
9259a1c
Add more options menu to live room interface
Copilot Dec 14, 2025
fae4fa5
Fix imports for live room header control
Copilot Dec 14, 2025
88fa019
Fix ActionRowLineItem import
Copilot Dec 14, 2025
bc04822
Address code review feedback: fix GlobalKey type and magic number
Copilot Dec 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/pages/live_room/controller.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import 'package:PiliPlus/models_new/live/live_room_play_info/codec.dart';
import 'package:PiliPlus/models_new/live/live_superchat/item.dart';
import 'package:PiliPlus/pages/danmaku/danmaku_model.dart';
import 'package:PiliPlus/pages/live_room/send_danmaku/view.dart';
import 'package:PiliPlus/pages/live_room/widgets/header_control.dart';
import 'package:PiliPlus/pages/video/widgets/header_control.dart';
import 'package:PiliPlus/plugin/pl_player/controller.dart';
import 'package:PiliPlus/plugin/pl_player/models/data_source.dart';
Expand Down Expand Up @@ -113,7 +114,7 @@ class LiveRoomController extends GetxController {

final showSuperChat = Pref.showSuperChat;

final headerKey = GlobalKey<TimeBatteryMixin>();
final headerKey = GlobalKey<LiveHeaderControlState>();

final RxString title = ''.obs;

Expand Down
9 changes: 8 additions & 1 deletion lib/pages/live_room/view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ import 'package:PiliPlus/pages/live_room/superchat/superchat_card.dart';
import 'package:PiliPlus/pages/live_room/superchat/superchat_panel.dart';
import 'package:PiliPlus/pages/live_room/widgets/bottom_control.dart';
import 'package:PiliPlus/pages/live_room/widgets/chat_panel.dart';
import 'package:PiliPlus/pages/live_room/widgets/header_control.dart';
import 'package:PiliPlus/pages/live_room/widgets/header_control.dart'
show LiveHeaderControl, LiveHeaderControlState;
import 'package:PiliPlus/pages/video/widgets/player_focus.dart';
import 'package:PiliPlus/plugin/pl_player/controller.dart';
import 'package:PiliPlus/plugin/pl_player/models/play_status.dart';
Expand Down Expand Up @@ -199,6 +200,12 @@ class _LiveRoomPageState extends State<LiveRoomPage>
child = PlayerFocus(
plPlayerController: plPlayerController,
onSendDanmaku: _liveRoomController.onSendDanmaku,
onShowMenu: () {
final headerState = _liveRoomController.headerKey.currentState;
if (headerState is LiveHeaderControlState) {
headerState.showSettingSheet();
}
},
child: child,
);
}
Expand Down
Loading
Loading