fix: Correct subtitle toggle behavior in player options - #253
fix: Correct subtitle toggle behavior in player options#253google-labs-jules[bot] wants to merge 1 commit into
Conversation
The subtitle option in the player's "more options" menu was not functioning as a toggle. It incorrectly opened a subtitle settings dialog and failed to update the UI state, causing it to become unresponsive. This commit refactors the subtitle option into a `SwitchListTile` that directly toggles the subtitle visibility. A new `toggleSubtitle` function has been added to the `VideoDetailController` to manage the subtitle state, ensuring the UI correctly reflects whether subtitles are on or off. This resolves the bug and aligns the subtitle option's behavior with user expectations.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
The subtitle option in the player's "more options" menu was not functioning as a toggle. It incorrectly opened a subtitle settings dialog and failed to update the UI state, causing it to become unresponsive. This commit refactors the subtitle option into a
SwitchListTilethat directly toggles the subtitle visibility. A newtoggleSubtitlefunction has been added to theVideoDetailControllerto manage the subtitle state, ensuring the UI correctly reflects whether subtitles are on or off. This resolves the bug and aligns the subtitle option's behavior with user expectations.Fixes #249
PR created automatically by Jules for task 11583074045065897937 started by @UcnacDx2