Skip to content

Remove subtitle toggle that hardcodes selection to index 1 #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: feat/add-player-settings-buttons-9885815689951910001
Choose a base branch
from
Draft

Remove subtitle toggle that hardcodes selection to index 1 #248

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a23434
Initial plan
Copilot Dec 14, 2025
7cf6124
fix: Remove subtitle toggle that hardcodes to index 1
Copilot Dec 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions lib/pages/video/widgets/header_control.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ mixin TimeBatteryMixin<T extends StatefulWidget> on State<T> {
SliverList.builder(
itemCount: videoDetailCtr.subtitles.length + 1,
itemBuilder: (context, index) {
final bool isCurrent = videoDetailCtr.subtitle.value == index;
final bool isCurrent = videoDetailCtr.vttSubtitlesIndex.value == index;
return ListTile(
dense: true,
onTap: () {
Expand Down Expand Up @@ -1384,14 +1384,6 @@ class HeaderControlState extends State<HeaderControl>
leading: const Icon(Icons.subtitles_outlined, size: 20),
title: const Text('字幕', style: titleStyle),
),
SwitchListTile(
value: videoDetailCtr.vttSubtitlesIndex.value > 0,
onChanged: (value) {
videoDetailCtr.setSubtitle(value ? 1 : 0);
},
secondary: const Icon(Icons.subtitles_outlined, size: 20),
title: const Text('开启字幕', style: titleStyle),
),
ListTile(
dense: true,
onTap: () {
Expand Down
Loading