Properly expect EOF after parser exits#117
Merged
Merged
Conversation
Lotes
reviewed
Jun 24, 2026
| parserState.ReportMatch() | ||
| return la2, true | ||
| } | ||
| // Most other parser generators would attempt single-token insertion here |
Collaborator
There was a problem hiding this comment.
Update the comment? You are refering to nil tokens. I am not sure if this is still given, since you changed the if conditions.
Member
Author
There was a problem hiding this comment.
RecoverInline is called in ParserState.Consume. Consume still returns nil tokens, when they don't match the expected token - the comment is therefore still correct. Note that RecoverInline actually returns nil, not the EOF token.
Lotes
approved these changes
Jun 24, 2026
Lotes
left a comment
Lotes
left a comment
Collaborator
There was a problem hiding this comment.
Looks straight forward. Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While we are perfectly capable of telling whether an input is too short (because parsing it fails), we're currently too lenient when an input is "too long" (i.e. the parser has already exited, but there are more tokens available).
This change addresses this by adding a dedicated
ExpectEndOfInputmethod to the parser state, which generates an error on the first extra token it sees after the parser exits.