Fix completion after grammar action#116
Merged
Merged
Conversation
msujew
force-pushed
the
msujew/fix-action-ref-completion
branch
from
a0e0c1d to
534102d
Compare
msujew
force-pushed
the
msujew/fix-action-ref-completion
branch
from
534102d to
e5bc1f5
Compare
ssmifi
approved these changes
Jun 24, 2026
ssmifi
left a comment
ssmifi
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, just a guarding question and some minor remarks.
msujew
force-pushed
the
msujew/fix-action-ref-completion
branch
from
99429e5 to
08b2838
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes a tiny part of #98 to fix the completion after executing an action. Previously, synthetic objects had the wrong type after an action. That's because they used the Rule type name, instead of the actual computed interface name - which differs after actions.
Because of a minor parser generator issue if actions appear right at the start of the rule, I had to re-generate all parsers. This makes up 99% of the changes of this PR :)
The actual test for this is in the
TestCompletion_AfterO_ActionCrossReftest.