Conversation
There was a problem hiding this comment.
Pull request overview
This PR refreshes the HTML exercise pages and repository metadata by moving inline styling into embedded CSS, improving semantic structure, and expanding the README to better document the exercises and demo assets.
Changes:
- Refactor HTML exercise pages to use semantic elements (
main/section/nav/article), responsive layout, and cleaner CSS (replacing inline styles/legacy HTML attributes). - Update the tea menu content to be tea-specific (instead of duplicating coffee text) and improve table structure (
thead/tbody, captions, scoped headers). - Improve repository documentation/configuration via README structure updates, funding config cleanup, and stronger text/EOL normalization in
.gitattributes.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Rewrites README with summary, structure list, and a centered demo image. |
| exercise_1/index.html | Refactors to semantic structure + embedded responsive CSS for the basic Coffee/Tea intro page. |
| exercise_2/index.html | Refactors exercise_2 landing page with internal navigation, embedded CSS, and accessible images. |
| exercise_2/coffee/coffee.html | Refactors coffee menu into semantic sections + CSS; modernizes pricing table markup. |
| exercise_2/tea/tea.html | Refactors tea menu into semantic sections + CSS; corrects tea-specific content and table markup. |
| exercise_summary/index.html | Refactors the summary exercise into a reusable panel layout with embedded CSS and better semantics. |
| .github/FUNDING.yml | Simplifies funding config and converts custom to a YAML list. |
| .gitattributes | Adds explicit LF normalization rules and documents intent alongside existing LFS image rules. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ## Hình ảnh demo | ||
|
|
||
| <p align="center"> | ||
| <img src="pic/0.jpg" alt="Ảnh demo giao diện bài tập HTML" style="width: 100%; max-width: 720px; height: auto;"> |
| <title>Bài Tập Tổng Hợp</title> | ||
|
|
||
| <style> | ||
| /* Page layout: centers the summary panel and keeps it readable on mobile. */ |
Comment on lines
+104
to
+105
| <a href="#coffee">Click để tìm hiểu về Coffee</a> | ||
| <a href="#tea">Click để tìm hiểu về Tea</a> |
Comment on lines
+181
to
+182
| <a href="../index.html">Click để về trang Index</a> | ||
| <a href="../tea/tea.html">Click để tới trang Tea</a> |
Comment on lines
+166
to
+167
| <a href="../index.html">Click để về trang Index</a> | ||
| <a href="../coffee/coffee.html">Click để tới trang Coffee</a> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.