Fix RGBA image rendering#146
Closed
sastraxi wants to merge 3 commits into
Closed
Conversation
Contributor
Author
|
Already landed in wifi menu branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I introduced a PNG (different branch) that had a yellow transparent background, I saw a yellow box where I expected the icon to be.
We need to provide a mask to the draw call to fix this; without a mask,
paste(src, loc)does a raw pixel copy, ignoring the alpha channel entirely and overwriting destination pixels with the source's RGB values. This has two effects:In test snapshots, semi-transparent fringe pixels got their raw RGB values stamped onto the destination at full opacity, creating halos or bleed around icon edges.
In production, PIL converted the source to RGB, meaning the background colour came with it at full opacity (pre-composited). Fortunately,
Widget._do_drawalways calls_draw_erasebefore_draw, so there's no accumulation risk.