Use git pull to update pedalboards#144
Open
sastraxi wants to merge 13 commits into
Open
Conversation
# Conflicts: # modalapi/modhandler.py
# Conflicts: # pistomp/handler.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the "Update sample pedalboards" flow (which ran a script that overwrote the sample pedalboards from a fixed remote) with "Sync pedalboards", which pulls/merges from a user-configured git remote. This config value lives in default_config.yml, e.g.
Local edits are preserved across syncs, to the extent git allows it. Update status (including conflicts) show up on the LCD. This includes:
Persistent notification icon
A new orange alert icon appears on the LCD whenever the last sync attempt left a problem (conflicts, network error, remote mismatch, etc.) — so the user knows their pedalboards are out of sync without re-opening the menu. It clears automatically once a sync succeeds.
First-boot behavior
If ~/.pedalboards is missing/empty and a remote is configured, pi-stomp clones it automatically at startup rather than requiring the user to SSH in. This supplements the behaviour provided by pi-gen-pistomp et al.