-
Notifications
You must be signed in to change notification settings - Fork 24
feat(desktop): support adaptive tool timeouts #409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
karry-0803
wants to merge
5
commits into
TouchAI-org:main
Choose a base branch
from
karry-0803:feat/llm-adaptive-tool-timeout-clean
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
85e6a6e
feat(desktop): support adaptive tool timeouts
karry-0803 c12b88f
fix(desktop): add min/max to timeout schema; enforce integer; use sha…
karry-0803 80d10d3
fix(desktop): always strip invalid timeout metadata
karry-0803 1ef69a5
style(desktop): keep timeout sanitization on one line
karry-0803 f6f5185
Merge branch 'main' into feat/llm-adaptive-tool-timeout-clean
karry-0803 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| export function clampTimeoutMs( | ||
| requested: number | undefined | null, | ||
| fallback: number, | ||
| min = 1000, | ||
| max = 600000 | ||
| ): number { | ||
| if (typeof requested !== 'number' || !Number.isFinite(requested)) { | ||
| return fallback; | ||
| } | ||
| const integer = Math.floor(requested); | ||
| const bounded = Math.min(Math.max(integer, min), max); | ||
| return bounded; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick | 🔵 Trivial | ⚡ Quick win
Consider simplifying the sanitization copy logic.
The conditional shallow copy at line 355 works correctly but is more complex than necessary. The code only creates a copy when
_metaexists, then deletes it. A simpler and safer approach would be to always copy and always delete:This is clearer (one code path instead of two) and safer (always returns a new object, preventing potential reference-based mutations).
♻️ Proposed refactor
function parseRequestedTimeoutMs(toolArgs: Record<string, unknown>): { requestedTimeoutMs?: number; sanitizedToolArgs: Record<string, unknown>; } { const meta = toolArgs[TOOL_TIMEOUT_META_KEY]; - const sanitizedToolArgs = TOOL_TIMEOUT_META_KEY in toolArgs ? { ...toolArgs } : toolArgs; - if (TOOL_TIMEOUT_META_KEY in sanitizedToolArgs) { - delete sanitizedToolArgs[TOOL_TIMEOUT_META_KEY]; - } + const sanitizedToolArgs = { ...toolArgs }; + delete sanitizedToolArgs[TOOL_TIMEOUT_META_KEY]; if (!meta || typeof meta !== 'object' || Array.isArray(meta)) { return {🤖 Prompt for AI Agents