feat(client): implement an engineio client based on Stream + Sink#757
Draft
Totodore wants to merge 22 commits into
Draft
feat(client): implement an engineio client based on Stream + Sink#757Totodore wants to merge 22 commits into
Totodore wants to merge 22 commits into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+135
to
+136
| if let Some(size) = | ||
| Self::validate_payload_size(v, this.sent_bytes, this.max_payload) => |
Merging this PR will improve performance by 10.1%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | Encode packet event on / |
3.7 µs | 4.2 µs | -11.36% |
| ⚡ | Encode packet binary ack on / |
3.8 µs | 3.3 µs | +16.32% |
| ⚡ | Encode packet ack on / |
3.8 µs | 3.3 µs | +16.17% |
| ⚡ | Encode packet binary event on / |
3.8 µs | 3.3 µs | +14.26% |
| ⚡ | Encode packet event with ack on / |
3.8 µs | 3.3 µs | +13.39% |
| ⚡ | Encode packet connect on / |
5.2 µs | 4.6 µs | +11.65% |
| ⚡ | Encode packet ack on /custom_nsp |
4.8 µs | 4.3 µs | +11.57% |
| ⚡ | Encode packet connect on /custom_nsp |
5.2 µs | 4.7 µs | +10.94% |
| ⚡ | Encode packet binary ack on /custom_nsp |
4.8 µs | 4.3 µs | +10.9% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing engineioxide-client-impl (3b252ed) with main (8ffc141)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.