Move graphflood/define_types.h into topotoolbox.h#231
Merged
Conversation
Having multiple external header files makes it a little tricker to install libtopotoolbox. The graphflood/define_types.h header only defines a few macros, so it is easy enough to include in the main topotoolbox.h file. All of the references to graphflood/define_types.h are replaced with topotoolbox.h in the graphflood source. Signed-off-by: William Kearney <[email protected]>
Contributor
|
@wkearn yes, that's all good and cleaner ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having multiple external header files makes it a little tricker to
install libtopotoolbox. The graphflood/define_types.h header only
defines a few macros, so it is easy enough to include in the main
topotoolbox.h file.
All of the references to graphflood/define_types.h are replaced with
topotoolbox.h in the graphflood source.
@bgailleton: is this all right?