Migrate WritePoint to unsafe native pointer and split LasPoint.cs#12
Merged
Conversation
- Extract LasZipPointNative to its own file with new WriteFromLasPoint method - Extract LasZipPointStruct to its own file, marked [Obsolete] - Rewrite WritePoint to use LasZipPointNative* instead of Marshal.StructureToPtr - Remove legacy ConvertPoint(LasZipPointStruct) overload from LasPoint - Fix bug where old WritePoint mutated caller's point coordinates Closes #11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidate around
LasZipPointNativefor both read and write paths, replacingMarshal.StructureToPtrwith direct unsafe pointer writes inWritePoint. Split the multi-typeLasPoint.csfile into one-type-per-file.Changes
LasZipPointNative.cs(new) — extracted struct + addedWriteFromLasPointfor the write pathLasZipPointStruct.cs(new) — extracted struct marked[Obsolete], retained for backward compatibilityLasPoint.cs— trimmed to only contain theLasPointclassLasZip.cs—WritePointrewritten to useunsafe LasZipPointNative*pointer writesBug fix
The old
WritePointwas mutating the caller'spoint.X/Y/Zto scaled integer values before writing. The new implementation writes directly to the native pointer without modifying the input.Closes #11