Skip to content

fix(opencode): declare session http errors - #3

Merged
TimothyVang merged 1 commit into
mainfrom
agent/m5-http-error-contracts
Jul 8, 2026
Merged

fix(opencode): declare session http errors#3
TimothyVang merged 1 commit into
mainfrom
agent/m5-http-error-contracts

Conversation

@TimothyVang

Copy link
Copy Markdown
Owner

Summary

  • declare explicit session.list BadRequest and session.diff BadRequest/NotFound contracts
  • keep SessionSummary.diff missing-session failures on the Effect error channel
  • map diff NotFound to the declared legacy API not-found body at the HTTP boundary

Verification

  • bun test test/session/summary.test.ts test/server/httpapi-session.test.ts test/server/session-diff-missing-patch.test.ts test/server/httpapi-public-openapi.test.ts test/server/httpapi-query-schema-drift.test.ts
  • bun run typecheck
  • bun run test:httpapi
  • bun run check:generated (packages/client)
  • umask 022 && bun test
  • git diff --check

Note: a default shell umask of 0002 caused the existing test/tool/write.test.ts mode assertion to see 0664 instead of 0644 on the first full-suite run; rerunning the full suite with umask 022 passed.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

@TimothyVang
TimothyVang merged commit 6d359ea into main Jul 8, 2026
8 of 9 checks passed
@TimothyVang
TimothyVang deleted the agent/m5-http-error-contracts branch July 8, 2026 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant