-
Notifications
You must be signed in to change notification settings - Fork 0
feat: OPENCODE_TOOL_CHOICE=required for agent tool binding #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| import { describe, expect, test } from "bun:test" | ||
|
|
||
| describe("OPENCODE_TOOL_CHOICE / VERDICT_FORCE_TOOL_CHOICE", () => { | ||
| test("reads required from OPENCODE_TOOL_CHOICE", async () => { | ||
| const prev = process.env["OPENCODE_TOOL_CHOICE"] | ||
| const prevForce = process.env["VERDICT_FORCE_TOOL_CHOICE"] | ||
| try { | ||
| delete process.env["VERDICT_FORCE_TOOL_CHOICE"] | ||
| process.env["OPENCODE_TOOL_CHOICE"] = "required" | ||
| // Re-import would cache Flag getters — getters read process.env at access time. | ||
| const { Flag } = await import("../src/flag/flag") | ||
| expect(Flag.OPENCODE_TOOL_CHOICE).toBe("required") | ||
| } finally { | ||
| if (prev === undefined) delete process.env["OPENCODE_TOOL_CHOICE"] | ||
| else process.env["OPENCODE_TOOL_CHOICE"] = prev | ||
| if (prevForce === undefined) delete process.env["VERDICT_FORCE_TOOL_CHOICE"] | ||
| else process.env["VERDICT_FORCE_TOOL_CHOICE"] = prevForce | ||
| } | ||
| }) | ||
|
|
||
| test("VERDICT_FORCE_TOOL_CHOICE=1 maps to required", async () => { | ||
| const prev = process.env["OPENCODE_TOOL_CHOICE"] | ||
| const prevForce = process.env["VERDICT_FORCE_TOOL_CHOICE"] | ||
| try { | ||
| delete process.env["OPENCODE_TOOL_CHOICE"] | ||
| process.env["VERDICT_FORCE_TOOL_CHOICE"] = "1" | ||
| const { Flag } = await import("../src/flag/flag") | ||
| expect(Flag.OPENCODE_TOOL_CHOICE).toBe("required") | ||
| } finally { | ||
| if (prev === undefined) delete process.env["OPENCODE_TOOL_CHOICE"] | ||
| else process.env["OPENCODE_TOOL_CHOICE"] = prev | ||
| if (prevForce === undefined) delete process.env["VERDICT_FORCE_TOOL_CHOICE"] | ||
| else process.env["VERDICT_FORCE_TOOL_CHOICE"] = prevForce | ||
| } | ||
| }) | ||
| }) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
OPENCODE_TOOL_CHOICE=requiredorVERDICT_FORCE_TOOL_CHOICE=1is set for an agent without a configuredstepslimit (the built-in build agent leavesstepsunset),isLastStepnever becomes true, so every provider turn is sent withtoolChoice: "required". Any local tool call then setsneedsContinuationand the runner starts another turn that again cannot produce a final text answer, causing default sessions to keep issuing tools until an error/context limit instead of settling. Only forcerequiredwhen there is a finite final step or otherwise disable it after tool settlement.Useful? React with 👍 / 👎.