fix(opencode): stop slash versions hanging on git ls-remote - #13
Merged
Conversation
Branch-derived preview versions like 0.0.0-agent/m4-… made npm-package-arg treat @opencode-ai/plugin pins as github remotes, blocking seal smoke on git ls-remote. Sanitize channel/version at build and skip unsafe pins.
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Branch-stamped preview builds like 0.0.0-agent/m4-… made npm-package-arg treat @opencode-ai/plugin pin as a GitHub remote and block on git ls-remote. Sanitize channel/version labels at build time and skip unsafe pins at runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Live m17 seal smoke hung after
verdict · localwith a child process:Root cause is harness-owned: branch-derived preview builds stamp
OPENCODE_VERSION=0.0.0-<branch>-…. When<branch>contains/(e.g.
agent/m4-…), config dependency install pins@opencode-ai/[email protected]/m4-…. npm-package-arg treats that as aGitHub remote and arborist blocks on
git ls-remote.Fix
/→-inScript.channel/Script.versionat build time.pluginDependencyVersion()skips slash-containing pins for@opencode-ai/plugininstall in config + TUI config.Evidence
spark-local-seal-smoke/verdict run --purenpa('@opencode-ai/[email protected]/m4-…').type === 'git'npa('@opencode-ai/[email protected]…').type === 'version'Test plan
bun test test/installation-version.test.tsinpackages/core(3 pass)bash scripts/check-httpapi-error-contracts.sh(26 pass / 0 fail)verdictbinary and re-run seal smoke (needs caseforge/engine install of this tip; not claimed here)Not claimed
used_fallback=0