test(opencode): Ollama OpenAI-compat baseURL /v1 residual - #12
Conversation
Document that caseforge agent 404 (plain "404 page not found") is from a bare Ollama root missing /v1, not a provider path bug in this runtime. Preserve baseURL as configured; optional smoke for live /v1/chat/completions.
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 88cc2e505e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| origin="${raw%/}" | ||
| origin="${origin%/v1}" | ||
| v1_chat="${origin}/v1/chat/completions" |
There was a problem hiding this comment.
Reject bare VERDICT_LLM_BASEURL in smoke test
When VERDICT_LLM_BASEURL is set to the misconfigured bare Ollama root (http://host:11434), this script strips/normalizes it into origin and then probes ${origin}/v1/chat/completions, so it reports PASS even though the runtime would still POST to ${VERDICT_LLM_BASEURL}/chat/completions and hit the documented 404 page not found. Since this smoke check is meant to catch that exact missing-/v1 configuration, validate the supplied base URL (or probe the raw configured request path) before constructing the corrected /v1 URL.
Useful? React with 👍 / 👎.
Summary
bash scripts/check-httpapi-error-contracts.shpasses (26 tests).@ai-sdk/openai-compatiblePOSTs${baseURL}/chat/completions; Ollama only serves that under/v1. BareVERDICT_LLM_BASEURL=http://host:11434hits/chat/completions→ plain page-not-found. Normalization belongs in caseforge (engine lane)./v1); optional smokescripts/check-ollama-openai-compat.sh; short note inVERDICT-FORK.md.Evidence
Test plan