chore(engine): subtree pull opencode used_fallback (0e98eac) - #39
Conversation
0e98eac feat(opencode): emit used_fallback from native LLM runtime gate 8bcd306 Merge pull request #18 from TimothyVang/m27-cloud-local git-subtree-dir: engine git-subtree-split: 0e98eac62bdce929d828de7772ba34c096788a79
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4ac3602b07
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "llm.runtime": "ai-sdk", | ||
| "llm.provider": input.model.providerID, | ||
| "llm.model": input.model.id, | ||
| "llm.used_fallback": true, |
There was a problem hiding this comment.
When OPENCODE_EXPERIMENTAL_NATIVE_LLM is unset or false, control skips the native gate and reaches this unconditional AI-SDK branch. The session LLM boundary makes AI SDK the default and native an opt-in path, so emitting llm.used_fallback=true here marks every default request as a fallback even though no fallback occurred; any harness or metrics reading this field will misclassify normal runs. Only set this value when the native gate actually rejected a native attempt, or expose a separate runtime/default indicator.
Useful? React with 👍 / 👎.
1 participant
Summary
0e98eacintoengine/so the embedded harness emitsused_fallbackfrom the native LLM runtime gate.engine/paths).Test plan
engine/packages/opencode/...(3 files)npm run typecheckclean on caseforge worktree