docs(refactoring): refresh R2 status after #35#36
Merged
Conversation
R2 still claimed the transformer migration was entirely outstanding, which stopped being true at #33 and #35. Record the real position: 3 of 11 migrated, and those three are exactly the boundary-crossing ones. Replace the vague "migrate the ~10 transformers" with a priority-ordered table, so the sequencing rationale survives the session that produced it. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R2's status line still read "helpers landed (#31); transformer migration outstanding", which stopped being true at #33 and #35.Refreshes it to the actual position — 3 of 11 transformers migrated, namely the three that cross the scope boundary — and replaces the vague "migrate the ~10 transformers" with a priority-ordered table carrying the remaining
SqlExpression::pattern count per file.Ordering rationale, so the next session doesn't have to rederive it:
having_alias_transformerfirst: it's P9, the only one with a live wrong answer (HAVING COUNT(*) BETWEEN 1 AND 2→ 4 rows vs DuckDB's 1, silently). Corpus case before the migration.map_childrenis load-bearing for them.WindowSpec::order_bywarning: no blanket "pure refactor" claims, since two of the bugs refactor(query_plan): migrate the three boundary-crossing transformers onto walk.rs (R2, group 1) #33 fixed were exactly that.Docs only.
🤖 Generated with Claude Code