Added missing command registration support for the Qbox framework module.#193
Open
PeppeSess wants to merge 3 commits into
Open
Added missing command registration support for the Qbox framework module.#193PeppeSess wants to merge 3 commits into
PeppeSess wants to merge 3 commits into
Conversation
Added missing command registration support for the Qbox framework module. The ESX and QBCore framework modules already expose `Framework.Commands.Add`, but the Qbox module did not define `Framework.Commands`, causing resources that rely on the unified Community Bridge command API to fail on Qbox
gononono64
reviewed
May 5, 2026
Contributor
|
Minor issue but rest looks good. Needs testing |
fixed a small careless error
Author
|
Commit updated, thanks |
MrNewb
reviewed
May 15, 2026
| end) | ||
|
|
||
| return Framework No newline at end of file | ||
| AddEventHandler("playerDropped", function() |
Contributor
|
@PeppeSess |
removed duplicates
Author
everything should be okay now, sorry for the delay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added missing command registration support for the Qbox framework module.
The ESX and QBCore framework modules already expose
Framework.Commands.Add, but the Qbox module did not defineFramework.Commands, causing resources that rely on the unified Community Bridge command API to fail on Qbox with:This PR adds
Framework.Commands.Addto the Qbox server framework module usinglib.addCommand, while preserving the same public bridge API used by the other framework modules.Admin-restricted commands are checked through the existing Qbox bridge admin resolver:
This keeps command registration consistent across the different frameworks
Testing Steps
field 'Commands'being nil.permission = "user"and confirmed it executes successfully.permission = "admin"and confirmed it only executes whenFramework.GetIsFrameworkAdmin(source)returns true.Additional Notes
This change aligns the Qbox framework module with the existing ESX and QBCore bridge structure by exposing the same
Framework.Commands.AddAPI.The implementation uses
lib.addCommand, which is already available through Community Bridge’s ox_lib dependency.