chore(iobroker.teslemetry): enable npm publish#59
Merged
Conversation
Drop private:true now that the prior packaging blockers (io-package.json sync, admin icon) are merged. Also fixes io-package.json version/news drift that crept back in after the 0.1.10 dependency bump, and adds a changeset so the next Version Packages PR includes this release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
iobroker.teslemetrystill hadprivate: true, so the changesets publish pipeline (pnpm run ci:publishin.github/workflows/publish.yml) skips it even though the two prior repochecker blockers (io-package.jsonversion/news sync, admin icon) are already merged (fix(iobroker.teslemetry): sync io-package.json version/news and add admin icon #53).private: truefrompackages/iobroker.teslemetry/package.json.io-package.jsonhad drifted again - the 0.1.10 dependency-bump release (@teslemetry/[email protected]) went out via the version-packages pipeline, which only touchespackage.json/CHANGELOG.md, soio-package.json'scommon.versionwas back to0.1.9with no0.1.10news entry.common.versionto0.1.10and added the matching news entry..changeset/iobroker-first-publish.md) so the next Version Packages PR picks up this package and mints its first real npm release.Testing
pnpm --filter iobroker.teslemetry build- cleanpnpm --filter iobroker.teslemetry check- cleanpnpm --filter iobroker.teslemetry test- 30/30 passpnpm lint- cleanThis PR does not publish anything itself - merging it lets changesets open a "Version Packages" PR for
iobroker.teslemetry; publishing to npm happens only when that follow-up PR is merged, via the existing OIDC/provenance publish step.Next steps (outward, after npm publish)
Publishing to npm is half of going live - the adapter also needs listing in the ioBroker adapter store, which is a separate manual submission against
ioBroker/ioBroker.repositories:iobroker.teslemetryexists on npm, open a PR there adding an entry tosources-dist.jsonpointing at this package (npm and/or GitHub source).@iobroker/repocheckeragainst the submission - it needs the npm package to already be published to fetch and check the tarball, checksio-package.jsonmetadata (version/news sync, icon, license, type, all fields this PR and fix(iobroker.teslemetry): sync io-package.json version/news and add admin icon #53 already keep in sync), README structure, and repo conventions (LICENSE file, changelog format).