Add unit tests for cumulative energy meter offset/rollover logic#17
Merged
Conversation
Covers offset initialization, same-day accumulation, day rollover across single and multiple boundaries, and the destroyed-device guard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
updateCumulativeMeterinlib/TeslemetryDevice.ts, which has no tests today despite three past releases (0.1.2, 0.1.3, 0.2.0) fixing energy-meter/unit-conversion bugs in this areadestroyedis set, including mid-flight after the offset write but before the rest of the update completeslib/TeslemetryDevice.tsis untouchedNote for reviewers
Writing these tests surfaced a gap, not fixed here: the day-rollover check only triggers on a
dateKeychange. A same-day raw reading that comes back lower than the previous one (e.g. a transient API glitch) is not guarded against and passes straight through as a decreasing capability value, which is exactly the kind of regression Homey's cumulative-meter energy tracking assumes can't happen. See thepasses a lower same-day raw reading straight through as a decreasing valuetest, which documents the current behavior rather than asserting a fix. Flagging for a separate PR if that's worth guarding against.