Fix vehicle SSE listener leak on device uninit#16
Merged
Conversation
VehicleDevice.onUninit called sse.data.removeAllListeners(), which wipes every listener on the shared per-vehicle emitter (including any owned by the SDK) and never touched the state/connectivity listeners registered directly on sse. Register signals through a tracked onSignal wrapper and off() the state/connectivity handlers explicitly, mirroring the pattern already used in the energy drivers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
VehicleDevice.onUninitonUninitcalledthis.vehicle.sse.data.removeAllListeners(), which wipes every listener on the shared per-vehicle SSE emitter, not just this device's own - including any SDK-internal listeners. It also never touched thestate/connectivitylisteners registered directly onthis.vehicle.sse(as opposed to.sse.data), so those leaked and could double-register on device re-init or repair.onSignalwrapper that records the SDK's own unsubscribe function, and hoist thestate/connectivityhandlers to named class fields soonUninitcanoff()exactly what it registered - the same per-handler cleanup pattern already used in the energy drivers (e.g.drivers/battery/device.ts).test/vehicle-sse-teardown.test.tsprovingonUninitremoves exactly the device's own listeners from the shared emitter and leaves an unrelated listener untouched.