Mark Gateway/Solar devices unavailable when their energy site is missing#15
Merged
Conversation
…battery Gateway and Solar devices logged and silently returned when their energy site wasn't found on init, leaving the device looking available but dead. Vehicle and Powerwall already called setUnavailable in the equivalent path; align Gateway and Solar with that pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
setUnavailable(...)in this exact path; bring Gateway and Solar in line with that patterntest/device-oninit-no-product.test.tsalongside the existing Vehicle/Powerwall coveragewall_connector_statehandling already surfaces viathis.log(no change needed there)Init-failure paths are otherwise awkward to exercise end-to-end (no live Teslemetry site to fail against), so coverage here is limited to the device-stub unit tests already used for Vehicle/Powerwall.