fix: validate Blend adapter constructor addresses#439
Conversation
…7-4c2f-9488-30308ab956d6) Reject account-form admin, vault, and pool addresses before persisting Blend adapter constructor config.\n\nRED: cargo test -p templar-soroban-blend-adapter constructor_rejects_non_contract -- --nocapture failed with all three non-contract constructor cases accepted.\nGREEN: cargo test -p templar-soroban-blend-adapter constructor_rejects_non_contract -- --nocapture; cargo test -p templar-soroban-blend-adapter -- --nocapture; cargo fmt --check; git diff --check.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Superseded by #431, which consolidates the tracker-defined |
|
Closed as superseded by #431 consolidated adapter-accounting-and-blend-admin PR. |
Fixed Findings
6a5a3ec7-5477-4c2f-9488-30308ab956d6Summary
admin,vault, andpooladdresses during Blend adapter construction.Root Cause
The Blend adapter constructor accepted raw
Addressvalues and stored them without checking that deployment-bound authorities and dependencies were contract addresses. That allowed account-form addresses to be persisted for the admin/vault/pool configuration even though the adapter's runtime boundary expects contract-address dependencies.Verification
RED:
GREEN:
Stack
Base:
audit/adapter-admin-retarget-a035/ PR #438.This change is