Upgrade vite/vitest/plugin-react to patch esbuild advisory (GHSA-gv7w-rqvm-qjhr)#114
Merged
Merged
Conversation
…qvm-qjhr) esbuild < 0.28.1 was flagged (High, GHSA-gv7w-rqvm-qjhr). The patched 0.28.1 was incompatible with vite 6 (broke platform-ui transpile), so bump the toolchain to versions whose defaults tolerate it: - examples/platform-ui: vite ^6.4.2 -> ^8.0.16, @vitejs/plugin-react ^4.3.4 -> ^6.0.2 - root: vitest ^4.1.2 -> ^4.1.9 - pnpm overrides: pin vite ^8.0.16 (single version across workspace + vitest peer) and esbuild >=0.28.1 Verified: full workspace build green (incl. platform-ui on vite 8), 3292 tests pass, platform-ui typecheck clean. (The one failing test, examples/ota playground, needs network-downloaded airport data and is unrelated to this change.) https://claude.ai/code/session_01TwDq6fWRtNtPqxzYm4fshB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
esbuild
< 0.28.1is flagged High (GHSA-gv7w-rqvm-qjhr). This isn't just a Dependabot alert — CI runspnpm audit --audit-level=high, so the advisory fails CI. The patched esbuild0.28.1is incompatible with the pinnedvite 6(it brokeexamples/platform-ui's transpile with 92 errors), so the fix is a small toolchain bump to versions whose defaults tolerate it.What
vite(examples/platform-ui)@vitejs/plugin-react(examples/platform-ui)vitest(root)esbuild(transitive)pnpm
overridespin a singlevite ^8.0.16(covers platform-ui + vitest's peer) andesbuild >=0.28.1across the workspace. vite 8's higher default build target no longer forces the down-leveling that broke vite 6 with esbuild 0.28.Verified locally
esbuildresolves to a single 0.28.1 — clears the advisory /pnpm audit --audit-level=high.pnpm -r buildgreen across all 21 packages (platform-ui builds on vite 8).typecheckclean.examples/otaplayground) only occurs because it needspnpm run data:download, which my sandbox can't fetch (no network). CI runsdata:downloadbefore tests, so it passes there — not a regression from this change.No source/runtime code changes — dependency + lockfile only.
https://claude.ai/code/session_01TwDq6fWRtNtPqxzYm4fshB
Generated by Claude Code