fix: text analysis config and docs#472
Open
manuelporrasojeda wants to merge 7 commits into
Open
Conversation
manuelporrasojeda
commented
Jun 8, 2026
manuelporrasojeda
commented
Contributor
- Add Documentation to assert_text_analysis.
- Include Azure configuration from config if exist.
rgonalo
reviewed
Jun 9, 2026
| model_name="gpt-4o-mini", # optional | ||
| azure=False # set True for Azure OpenAI | ||
| ) | ||
|
|
Member
There was a problem hiding this comment.
después de Usage, añade una sección de Configuration, igual que en 'Text Similarity', para poner las variables de configuración
| OPENAI_API_VERSION=<your_api_version> | ||
|
|
||
| .. code-block:: text | ||
| [AI] |
Member
There was a problem hiding this comment.
no está bien formateado: https://github.com/Telefonica/toolium/blob/dfc00a183f924da7dc73ee15df158264a9d07ffd/docs/ai_utils.rst
creo que le falta una línea en blanco
| .. code-block:: text | ||
| [AI] | ||
| text_similarity_method: azure_openai | ||
| sentence_transformers_model: all-mpnet-base-v2 |
Member
There was a problem hiding this comment.
esta se podría quitar de este ejemplo
| if value: | ||
| kwargs.setdefault(key, value) | ||
| else: | ||
| for key in ('openai_api_key', 'openai_endpoint', 'openai_version', 'openai_deployment'): |
Contributor
There was a problem hiding this comment.
pero estos parametros no existen en el cliente de OpenAI , no?
Contributor
Author
There was a problem hiding this comment.
Toda la razón! ya pongo los buenos
pabloge
reviewed
Jun 9, 2026
Co-authored-by: Pablo Guijarro <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.