Skip to content

Fix PATH corruption on Unix/Linux: use os.pathsep instead of hardcoded semicolons #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YusDyr wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix PATH corruption on Unix/Linux: use os.pathsep instead of hardcoded semicolons #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pyogg/library_loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,8 @@ def load(name, paths = None, tests = []):

@staticmethod
def load_other(name, paths = None, tests = []):
os.environ["PATH"] += ";" + ";".join((os.getcwd(), _here))
if paths: os.environ["PATH"] += ";" + ";".join(paths)
os.environ["PATH"] += os.pathsep + os.pathsep.join((os.getcwd(), _here))
if paths: os.environ["PATH"] += os.pathsep + os.pathsep.join(paths)

for style in _other_styles:
candidate = style.format(name)
Expand All @@ -117,8 +117,8 @@ def load_other(name, paths = None, tests = []):

@staticmethod
def load_windows(name, paths = None, tests = []):
os.environ["PATH"] += ";" + ";".join((os.getcwd(), _here))
if paths: os.environ["PATH"] += ";" + ";".join(paths)
os.environ["PATH"] += os.pathsep + os.pathsep.join((os.getcwd(), _here))
if paths: os.environ["PATH"] += os.pathsep + os.pathsep.join(paths)

not_supported = [] # libraries that were found, but are not supported
for style in _windows_styles:
Expand Down