Skip to content

Remove explicit correction commands#205

Merged
masa10-f merged 3 commits into
masterfrom
codex/remove-correction-commands
Jun 5, 2026
Merged

Remove explicit correction commands#205
masa10-f merged 3 commits into
masterfrom
codex/remove-correction-commands

Conversation

@masa10-f
Copy link
Copy Markdown
Collaborator

Summary

Closes #200.

This removes explicit X and Z correction commands from measurement patterns and keeps output corrections in PauliFrame.

Changes

  • Remove graphqomb.command.X and graphqomb.command.Z from the command API.
  • Stop emitting terminal correction commands for unmeasured outputs in qompile().
  • Apply pending output Pauli-frame corrections in PatternSimulator before returning output statevectors or explicit output measurement results.
  • Store explicit output measurement results in PatternSimulator.output_results, keyed by logical output index.
  • Reject legacy .ptn X/Z command lines as unknown commands.
  • Update Stim compiler handling, docs, changelog, and regression tests.

Validation

  • uv run pytest -q
  • uv run ruff check graphqomb tests
  • uv run ruff format --check graphqomb tests
  • uv run --extra dev pyright
  • uv run --extra doc sphinx-build -b html docs/source docs/build/html

@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

❌ Patch coverage is 90.90909% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.62%. Comparing base (4db9357) to head (0a4e1b9).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #205      +/-   ##
==========================================
+ Coverage   85.28%   85.62%   +0.34%     
==========================================
  Files          25       25              
  Lines        3689     3674      -15     
  Branches      644      638       -6     
==========================================
  Hits         3146     3146              
+ Misses        394      379      -15     
  Partials      149      149              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@masa10-f
Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@masa10-f masa10-f marked this pull request as ready for review June 5, 2026 03:05
@masa10-f masa10-f self-assigned this Jun 5, 2026
@masa10-f masa10-f added the enhancement New feature or request label Jun 5, 2026
@masa10-f masa10-f merged commit a73cf5e into master Jun 5, 2026
24 checks passed
@masa10-f masa10-f deleted the codex/remove-correction-commands branch June 5, 2026 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove X and Z correction operators

1 participant