Take enable-cache and python-version into account when setting up uv in CI#516
Open
thierry-martinez wants to merge 1 commit into
Open
Take enable-cache and python-version into account when setting up uv in CI#516thierry-martinez wants to merge 1 commit into
enable-cache and python-version into account when setting up uv in CI#516thierry-martinez wants to merge 1 commit into
Conversation
… `uv` in CI The `setup-uv` composite action ignored the `enable-cache` and `python-version` inputs. Cache was still enabled by default, which is the intended behaviour, but the system Python version was used instead of the one specified. As a result, type‑checking and coverage ran with Python 3.12 rather than the requested Python 3.14. This commit fixes the `setup-uv` composite action so that it respects both the `enable-cache` and `python-version` inputs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #516 +/- ##
=======================================
Coverage 88.91% 88.91%
=======================================
Files 49 49
Lines 7111 7111
=======================================
Hits 6323 6323
Misses 788 788 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
setup-uvcomposite action ignored theenable-cacheandpython-versioninputs. Cache was still enabled by default, which is the intended behaviour, but the system Python version was used instead of the one specified. As a result, type‑checking and coverage ran with Python 3.12 rather than the requested Python 3.14.This commit fixes the
setup-uvcomposite action so that it respects both theenable-cacheandpython-versioninputs.