Skip to content

Add regression coverage for mismatched fluid/item IO warning pairs#552

Draft
Copilot wants to merge 2 commits into
1.19.2from
copilot/add-warnings-for-io-statements
Draft

Add regression coverage for mismatched fluid/item IO warning pairs#552
Copilot wants to merge 2 commits into
1.19.2from
copilot/add-warnings-for-io-statements

Conversation

Copilot AI commented Jun 15, 2026

Copy link
Copy Markdown

This issue asks for warnings when IO resource kinds are unpaired (e.g., INPUT fluid with default item OUTPUT, and vice versa). The linter logic already implements this behavior; this PR adds targeted coverage for the exact reported scenario.

  • What changed

    • Added a new migrated gametest:
      • UnusedIoWarningMismatchedItemAndFluidResourceKindsGameTest
    • The test program intentionally mixes resource kinds in one trigger:
      • INPUT fluid:: FROM left
      • OUTPUT TO left (defaults to item)
    • Assertions verify both warnings are emitted in the same run:
      • output resource kind missing from inputs (sfm:item)
      • input resource kind never consumed by outputs (sfm:fluid)
  • Why this matters

    • Locks in expected warning behavior for the specific mismatch pattern discussed in the issue.
    • Prevents regressions without changing production linting logic.
EVERY 20 TICKS DO
    INPUT fluid:: FROM left
    OUTPUT TO left
END

Copilot AI changed the title [WIP] Add warnings for io statements without a paired resource kind Add regression coverage for mismatched fluid/item IO warning pairs Jun 15, 2026
Copilot AI requested a review from TeamDman June 15, 2026 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants