provide info metadata to Nodes, Ways and Relations#40
Open
erictapen wants to merge 1 commit into
Open
Conversation
TeXitoi
requested changes
Nov 13, 2021
| #[derive(Debug, PartialEq, Eq, PartialOrd, Ord, Clone, Hash, Serialize, Deserialize)] | ||
| pub struct Info { | ||
| /// The timestamp when the object was introduced. | ||
| pub timestamp: Option<NaiveDateTime>, |
Owner
There was a problem hiding this comment.
I'm a bit worried by this:
- there is 2 options inside each ones, that makes it difficult to use
- the is_visible is obviously true if there is no info
- all this option thing will use a non negligible amount of memory.
I don't have yet any solution to all of this.
Author
There was a problem hiding this comment.
Mh yeah I'm not happy with the double Option either.
I think it makes sense to keep the Info object, as the osm protobuf definition provides some more fields like changeset and uid, so one might want to extend it in the future.
Not sure wether one could find an Info without a timestamp in the wild. I certainly didn't find one. Maybe it would make sense to make the timestamp non-optional?
Owner
There was a problem hiding this comment.
Sorry, forgot about this PR.
Yeah, I think we can:
- make timestamp non optional, outputing 0 in the rare case when we have no info
Option<NonZeroI64>, with some appropriate getters for ease of use. A timestamp of 0 is impossible as OSM didn't exist in 1970.
Author
There was a problem hiding this comment.
My OSM related project is on ice, so I won't be able to help further with this PR, sorry. Good luck!
This metadate is used in history dumps, as can be found at https://planet.openstreetmap.org/pbf/full-history/
jocelynj
added a commit
to jocelynj/osmpbfreader-rs
that referenced
this pull request
Apr 24, 2025
…bf file With cfg='full-metadata' enabled, these fields are available in an 'info' field of Node/Way/Relation object: - version - timestamp, as an i64 number, in milliseconds since 1970 epoch - changeset - user id - user name - visible, set to true by default This is greatly inspired from PR #TeXitoi#40, with the addition of more fields.
jocelynj
added a commit
to jocelynj/osmpbfreader-rs
that referenced
this pull request
Mar 15, 2026
…bf file With cfg='full-metadata' enabled, these fields are available in an 'info' field of Node/Way/Relation object: - version - timestamp, as an i64 number, in milliseconds since 1970 epoch - changeset - user id - user name - visible, set to true by default This is greatly inspired from PR #TeXitoi#40, with the addition of more fields.
jocelynj
added a commit
to jocelynj/osmpbfreader-rs
that referenced
this pull request
Mar 18, 2026
…bf file With cfg='full-metadata' enabled, these fields are available in an 'info' field of Node/Way/Relation object: - version - timestamp, as an i64 number, in milliseconds since 1970 epoch - changeset - user id - user name - visible, set to true by default This is greatly inspired from PR #TeXitoi#40, with the addition of more fields.
jocelynj
added a commit
to jocelynj/osmpbfreader-rs
that referenced
this pull request
Apr 8, 2026
…bf file With cfg='full-metadata' enabled, these fields are available in an 'info' field of Node/Way/Relation object: - version - timestamp, as an i64 number, in milliseconds since 1970 epoch - changeset - user id - user name - visible, set to true by default This is greatly inspired from PR #TeXitoi#40, with the addition of more fields.
jocelynj
added a commit
to jocelynj/osmpbfreader-rs
that referenced
this pull request
Apr 14, 2026
…bf file With cfg='full-metadata' enabled, these fields are available in an 'info' field alongside the Node/Way/Relation object: - version - timestamp, as an i64 number, in milliseconds since 1970 epoch - changeset - user id - user name - visible, set to true by default A specific iterator, iter_with_info() is added to get this field. This is inspired from PR #TeXitoi#40, with the addition of more fields.
jocelynj
added a commit
to jocelynj/osmpbfreader-rs
that referenced
this pull request
May 2, 2026
…bf file With cfg='full-metadata' enabled, these fields are available in an 'info' field alongside the Node/Way/Relation object: - version - timestamp, as an i64 number, in milliseconds since 1970 epoch - changeset - user id - user name - visible, set to true by default A specific iterator, iter_with_info() is added to get this field. This is inspired from PR #TeXitoi#40, with the addition of more fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for creating this library, I'm using it for a while now.
I needed this patch to process OSM history dumps, like the ones found at https://planet.openstreetmap.org/pbf/full-history/.
I was able to parse some 400MB large extracts using my patch without a problem.
This adds chrono as a dependency, as I felt that would be the best way to represent the timestamp.