chore: Added orchestrator tests#243
Draft
Volv-G wants to merge 2 commits into
Draft
Conversation
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Volv-G
force-pushed
the
volv/orchestrator-tests
branch
2 times, most recently
from
50f1f43 to
b026f88
Compare
…wer window The previous lockfile was missing the skypilot optional dependency group (53 packages) and its exclude-newer timestamp had drifted outside the rolling P7D window, both of which break uv sync --locked --all-extras in CI. Regenerated against public PyPI with UV_CONFIG_FILE=/dev/null to avoid picking up the user-level extra-index-url pointing at Shopify's internal mirror.
Volv-G
force-pushed
the
volv/orchestrator-tests
branch
from
b026f88 to
1b24674
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Adds a comprehensive test suite for the SQL-backed orchestrator service.
What changed?
Introduced
tests/test_orchestrator_sql.pywith a full set of unit tests forOrchestratorService_Sql. The tests cover both the queued and running execution processing queues, including:WAITING_FOR_UPSTREAMUNINITIALIZEDstatus executionsTERMINATEDdesired state, cancelling the target and skipping downstream tasksmax_cache_staleness=P0Dto disable reuseSYSTEM_ERRORand downstream skipsSYSTEM_ERRORand skipping downstreamprocess_each_queue_onceSupporting infrastructure includes
FakeLauncher,FakeLaunchedContainer, andFakeStorageProviderfakes, along with helper fixtures and utility functions for building pipeline graphs and driving executions to terminal states.How to test?
Run the new test module directly:
All tests use an in-memory SQLite database and fake implementations of the launcher and storage provider, so no external dependencies are required.
Why make this change?
The orchestrator is a critical component responsible for scheduling, caching, and lifecycle management of container executions. This test suite provides confidence that the core orchestration logic behaves correctly across a wide range of scenarios, including edge cases like partial termination votes, cache staleness policies, and error handling paths.