Update and clean up in det_manip#974
Open
Thoemi09 wants to merge 26 commits into
Open
Conversation
Thoemi09
force-pushed
the
DEV_DET_MANIP
branch
2 times, most recently
from
December 13, 2024 21:36
ac1a252 to
0372830
Compare
Reintroduce foreach for det_manip
- introduce remove specific working data - fix an inconsistency with a factor of +/-1 in the cached determinant and sign - add docs and rename variable to make them consistent with the docs
- introduce insert specific working data - add docs and rename variables to make them consistent with the docs
Fix nda::linalg::det call in det_manip_swap_row_col.cpp
- introduce change row/col specific working data
- introduce refill specific working data
Thoemi09
force-pushed
the
DEV_DET_MANIP
branch
from
February 11, 2026 22:42
f05dd9c to
013198d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following has been done:
det_manipclass