fix connection#38
Merged
Merged
Conversation
…derer iOS and Android switched to the platform video view as soon as the WebRTC client was ready, hiding SessionVideoPlaceholder before the connection finished and never re-showing any indicator during a Reconnecting state. Wrap the platform view in a Box and layer SessionStatusOverlay on top so the loading/reconnecting indicator stays visible through the full session lifecycle, matching the JVM/Desktop renderer structure. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
The DELETE-on-close behavior added in c1b9c6b assumed resourceUrl was already set on the session by the time close() ran, but the assignment was ordered AFTER setRemoteAnswer — which is a suspendCancellableCoroutine that can hang indefinitely when the peer never completes the answer callback (e.g. mock or malformed answer SDP). When that happens, resourceUrl is null at cleanup time and no DELETE is launched. The server already allocated the resource the moment sendOffer returned, so assign resourceUrl there, before setRemoteAnswer, on all three platforms (jvm, iOS, Android). E2E-V-04 close regression test additionally raced awaitSettled's 10s timeout against FULL_ICE's pre-offer gathering delay, calling close() while sendOffer was still in-flight. Wait for the offer POST to reach the mock server (a concrete signal that sendOffer returned and resourceUrl was assigned) before invoking close(). Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
PHOEBEHAUNG
added a commit
that referenced
this pull request
May 28, 2026
Merge pull request #38 from Syncrobotic/bugfix/fix-videoview-connecting-state-display fix connection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: assign resourceUrl before setRemoteAnswer so close() can DELETE
The DELETE-on-close behavior added in c1b9c6b assumed resourceUrl
was already set on the session by the time close() ran, but the
assignment was ordered AFTER setRemoteAnswer — which is a
suspendCancellableCoroutine that can hang indefinitely when the
peer never completes the answer callback (e.g. mock or malformed
answer SDP). When that happens, resourceUrl is null at cleanup time
and no DELETE is launched. The server already allocated the
resource the moment sendOffer returned, so assign resourceUrl
there, before setRemoteAnswer, on all three platforms (jvm, iOS,
Android).
E2E-V-04 close regression test additionally raced awaitSettled's
10s timeout against FULL_ICE's pre-offer gathering delay, calling
close() while sendOffer was still in-flight. Wait for the offer
POST to reach the mock server (a concrete signal that sendOffer
returned and resourceUrl was assigned) before invoking close().
Co-Authored-By: Claude Opus 4.7 (1M context) [email protected]