fix: avoid displaying Int.MAX_VALUE in reconnecting UI for unlimited retries#29
Conversation
…ing Int.MAX_VALUE Agent-Logs-Url: https://github.com/Syncrobotic/SyncAI-Lib-KmpWebRTC/sessions/0c0b38e5-df10-4764-8605-db86e87f44ce Co-authored-by: PHOEBEHAUNG <[email protected]>
|
@copilot CI 沒過,可以幫忙看看嗎 是環境問題嗎 |
|
@copilot ci 錯誤 e: file:///Users/runner/work/SyncAI-Lib-KmpWebRTC/SyncAI-Lib-KmpWebRTC/src/commonMain/kotlin/com/syncrobotic/webrtc/audio/SessionHelpers.kt:61:102 Argument type mismatch: actual type is 'Int?', but 'Int' was expected.
[Incubating] Problems report is available at: file:///Users/runner/work/SyncAI-Lib-KmpWebRTC/SyncAI-Lib-KmpWebRTC/build/reports/problems/problems-report.html 5 actionable tasks: 5 executed
|
… nullable maxAttempts Agent-Logs-Url: https://github.com/Syncrobotic/SyncAI-Lib-KmpWebRTC/sessions/2e2c6d7e-a076-4793-989a-e116c98d4818 Co-authored-by: PHOEBEHAUNG <[email protected]>
已修復。我漏了更新 Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
RetryConfig.PERSISTENTusesInt.MAX_VALUEfor unlimited retries, which was being displayed literally in the UI as "Reconnecting (1/2147483647)...".Changes
maxAttempts: Int→maxAttempts: Int?inSessionState.ReconnectingandPlayerState.Reconnecting, wherenull= unlimitedonAttemptcallback now passesnullinstead ofInt.MAX_VALUEfor unlimited retriesSessionHelpers.ktandPlayerState.displayNameto show "Reconnecting (N)..." when unlimitedBefore/After
Other Int.MAX_VALUE usages
Verified only other usage is in
WebRTCClient.ios.ktfor camera format sorting fallback—valid use case, no change needed.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
dl.google.com/usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED -Xmx4096M -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant -cp /home/REDACTED/.gradle/wrapper/dists/gradle-8.14.3-bin/cv11ve7ro1n3o1j4so8xd9n66/gradle-8.14.3/lib/gradle-daemon-main-8.14.3.jar(dns block)/usr/bin/curl curl -s REDACTED(dns block)/home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js(dns block)If you need me to access, download, or install something from one of these locations, you can either: