Skip to content

feat: service auth config - #311

Merged
Nexisato merged 14 commits into
mainfrom
feat/sso
Jun 29, 2026
Merged

feat: service auth config#311
Nexisato merged 14 commits into
mainfrom
feat/sso

Conversation

@Feudalman

Copy link
Copy Markdown
Member

sso 相关配置

@Feudalman
Feudalman requested a review from Nexisato June 25, 2026 11:16
@Feudalman Feudalman self-assigned this Jun 25, 2026
@Feudalman Feudalman added the enhancement New feature or request label Jun 25, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Chinese Kubernetes configuration documentation by renaming the configuration field global.settings.loginHost to global.settings.host and adding a recommendation for SSO configurations. The reviewer correctly identified that this renaming needs to be consistently propagated to other sections of the same file and to the corresponding English documentation to prevent inconsistencies.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread zh/self_host/kubernetes/configuration.md Outdated
@Nexisato

Copy link
Copy Markdown
Collaborator

中英文同步更新

@Feudalman

Copy link
Copy Markdown
Member Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Kubernetes configuration documentation in both English and Chinese to rename global.settings.loginHost to global.settings.host and adds guidance on configuring this field when using SSO. The review feedback suggests minor improvements, including fixing a spacing typo in the English documentation and aligning the Chinese description with the English version to explicitly mention configuring the field to the gateway's external URL.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread en/self_host/kubernetes/configuration.md Outdated
Comment thread zh/self_host/kubernetes/configuration.md Outdated
@Feudalman

Copy link
Copy Markdown
Member Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Kubernetes configuration documentation in both English and Chinese to rename the configuration field global.settings.loginHost to global.settings.host. It also adds recommendations for configuring this field when using SSO features. Feedback was provided to correct a minor spacing and punctuation typo in the English documentation.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread en/self_host/kubernetes/configuration.md Outdated
@Feudalman

Copy link
Copy Markdown
Member Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Kubernetes configuration documentation in both English and Chinese to rename the configuration field global.settings.loginHost to global.settings.host, and adds a recommendation to configure this field when using SSO features. The review feedback suggests improving the English phrasing for better readability and adding a "Breaking Change" warning in both languages to alert upgrading users about the renamed configuration field.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread en/self_host/kubernetes/configuration.md
Comment thread en/self_host/kubernetes/configuration.md
Comment thread zh/self_host/kubernetes/configuration.md
@Nexisato Nexisato closed this Jun 29, 2026
@Nexisato
Nexisato deleted the feat/sso branch June 29, 2026 05:39
@Nexisato
Nexisato restored the feat/sso branch June 29, 2026 05:41
@Nexisato Nexisato reopened this Jun 29, 2026
@Nexisato
Nexisato merged commit 3f7cc6e into main Jun 29, 2026
@Nexisato
Nexisato deleted the feat/sso branch June 29, 2026 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants