Replace variant fixtures with feature-named extension configs#10
Merged
Conversation
The retired variants' lint.py files under tests/fixtures/ existed only to keep engine knobs tested (membership, mermaid, staleness, index pinning, sync drift, reverse deps, ADRs, sharding, coverage). Replace them with plain feature-named config dicts in tests/extension_configs.py (infra / pinned-repo / sharded-repo) so nothing in the tree carries the old variant names. No feature or coverage loss; 91 tests green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The three retired-variant
lint.pyfiles undertests/fixtures/existed only to keep engine knobs exercised. This replaces them with plain, feature-named config dicts intests/extension_configs.py—infra(membership, mermaid,last_verifiedstaleness),pinned-repo(index pinning, sync drift, reverse-dependency fields, ADRs), andsharded-repo(subsystem sharding, coverage reports) — and renames the test references accordingly.No feature or coverage loss: same values, same 91 tests, all green. The old variant names no longer appear anywhere in the tree.