Skip to content

feat: Scorm MaxAttempts - #1302

Open
romitshah02 wants to merge 1 commit into
Sunbird-Knowlg:v1.0.3from
romitshah02:scorm-assesment
Open

feat: Scorm MaxAttempts#1302
romitshah02 wants to merge 1 commit into
Sunbird-Knowlg:v1.0.3from
romitshah02:scorm-assesment

Conversation

@romitshah02

Copy link
Copy Markdown
Contributor
  • SCORM 2004: reads attemptLimit off <imsss:limitConditions> in imsmanifest.xml (IMS Simple Sequencing), alongside the existing scoList/scormVersion extraction in ScormMimeTypeMgrImpl.
  • SCORM 1.2: no equivalent field in the spec — maxAttempts stays absent (unlimited), matching existing "not mentioned = no limit" semantics.
  • Stored under the same maxAttempts metadata key already used for QuestionSet, so course/v1/hierarchy returns it for SCORM nodes with zero portal-side changes.
  • Added maxAttempts to the obj-cat:scorm-content category definition (scripts/definition-scripts/SCORM_Content.sh) alongside launchFile/scormVersion/scoList.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Uploaded a SCORM 2004 package with <imsss:limitConditions attemptLimit="N"> in imsmanifest.xml, verified maxAttempts returned on content/v3/read
  • Uploaded a SCORM 1.2 package, verified maxAttempts is absent
  • Re-applied the obj-cat:scorm-content category definition update and verified schema validation accepts maxAttempts

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 98a73700-17c1-4cbb-b3bc-f1af51814469

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant