Tidy: type after param, drop duplicate test, Financial constraint, fire/flood phrasebank

[camlambert2000]

Summary

• Tighten routeToNextProfileQuestion after? param to a union of the six valid field names (no runtime change; catches bad call sites at compile time).
• Drop duplicate PNTS-on-children test; keep the PR refactor(profiling): PNTS selections store null not false; routeToNextProfileQuestion skips after-field #17 regression test which covers the same ground with a clearer name.
• Add Financial entry to needSubcategoryConstraints in serviceMatcher.ts, mirroring the Health and Work pattern — scopes support matches to debt-financial-problems and money-management.
• Add CRISIS_FIRE_FLOOD_LOCATION and __SUPPORTER phrasebank entries (previously called from crisis.ts but never defined in the phrasebank). Matches adjacent CRISIS_UNDER16_LOCATION pattern: 7 WMCA LAs + "Somewhere else".
• Backlog update: items 55 and 56 complete; item 59 visible.

Test plan

• npm test — 96 / 96 pass locally, including the fire/flood council-number tests that exercise the new phrasebank entries and the surviving PNTS-on-children regression test.
• CI green on staging.

🤖 Generated with Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
street-support-va-staging	Ready	Preview, Comment	Apr 22, 2026 0:45am
streetsupport-platform-va	Ready	Preview, Comment	Apr 22, 2026 0:45am

[james-cross]

Thanks for this.

Tidy PR.

One small follow-up thought: the existing fire/flood tests all start sessions at CRISIS_FIRE_FLOOD_LOCATION, which is why the missing phrasebank entry slipped past CI. A tiny regression test that starts at GATE0, selects 6, and asserts the rendered text doesn't include [Missing phrase: would protect any future safeguarding-adjacent prompt from the same class of bug. Not blocking, more a thought for the backlog.

[james-cross]

Nice work on this bit, good follow up from the last PR review.

It's worth considering one extra step:
needProfileRequirements just above this is still typed as Record<string, string[]>, so a typo like 'agee' in any of the requirements arrays would silently produce a never-matching branch in here. If we life the union to a shared alias and reuse it, the same protection applies to both.

Not blocking anything, just a small ergonomics win while we're in this file.

[james-cross]

Just to flag, this is a real bug fix worth calling out. Without these entries, anyone selecting option 6 at GATE0 would have seen [Missing phrase: CRISIS_FIRE_FLOOD_LOCATION] rendered through the phrase() fallback in shared.ts. Mirroring the CRISIS_UNDER16_LOCATION pattern is the right call here.

Nice work.