feat(stats): add miscellaneous stats#893
Open
ugcodrr wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
jacobk999
requested changes
Jun 11, 2026
jacobk999
left a comment
jacobk999
left a comment
Member
There was a problem hiding this comment.
Since there are a lot of profile changes. Add how the profiles look with the new stats to the PR description.
| import type { BaseProfileProps, ProfileTime } from "#commands/base.hypixel-command"; | ||
| import type { DuelsModeIcons } from "./duels.command.js"; | ||
|
|
||
| const formatTimeWithSeconds = (time: number) => formatTime(time, { entries: 3 }); |
Member
There was a problem hiding this comment.
Don't recreate this function in every file. Declare it once.
| public oneBlock: BedWarsMode; | ||
|
|
||
| @Field() | ||
| public armedDoubles: BedWarsMode; |
Member
There was a problem hiding this comment.
This is bad structure. You can use the dreams bedwars mode class maybe since I think it already has to do the sum. Just make it have overall, doubles and fours properties.
| this.warlords = new Warlords(stats.Battleground ?? {}); | ||
| this.woolgames = new WoolGames(stats.WoolGames ?? {}, achievements); | ||
|
|
||
| this.general.totalWins = add( |
Member
There was a problem hiding this comment.
I'm honestly not a fan of these stats since they will never really be accurate. I would avoid adding them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stat additions from PR #836