feat(badge): support emoji input#892
Open
ugcodrr wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
jacobk999
requested changes
Jun 11, 2026
| new TextArgument("emoji", (t) => t("arguments.emoji"), false), | ||
| ], | ||
| }) | ||
| public set(context: CommandContext) { |
Member
There was a problem hiding this comment.
Maybe just split files and emojis into two different subcommands, something along the lines of /badge emoji and /badge image. I am not a fan of having two arguments that could potentially conflict.
| const ctx = canvas.getContext("2d"); | ||
| ctx.imageSmoothingEnabled = false; | ||
|
|
||
| if (!["image/png", "image/jpeg", "image/gif"].includes(file.content_type ?? "")) |
Member
There was a problem hiding this comment.
Where webp the goat? This should probably be abstracted away into a constant.
| return canvas; | ||
| } | ||
|
|
||
| ctx.font = "28px Apple Color Emoji, Segoe UI Emoji, Noto Color Emoji, sans-serif"; |
Member
There was a problem hiding this comment.
I'm not a fan of the apple emoji. Can we get https://github.com/twitter/twemoji?
| const customEmoji = input.trim().match(/^<a?:\w+:(\d+)>$/); | ||
|
|
||
| if (customEmoji) { | ||
| const badge = await loadImage(`https://cdn.discordapp.com/emojis/${customEmoji[1]}.png?size=32&quality=lossless`); |
Member
There was a problem hiding this comment.
There should probably be handling if the bot can't load the emoji for whatever reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/badge setsupport for Discord emoji input.