Rename assets folder and ponder .nbt in renameMod#1
Merged
Conversation
The renameMod task renamed code and the mixin config but left the assets/examplemod folder and example_ponder.nbt untouched, and never rewrote the lang JSON contents. After a rename the ponder plugin looked for <id>_ponder.nbt while the file was still example_ponder.nbt, and the lang keys still said examplemod / example_. - Rewrite resource text files (lang jsons, mcmeta) alongside java/config; binary resources (.nbt/.png) are excluded so they are never mangled. - Rename resource files (example_ponder.nbt -> <id>_ponder.nbt, the mixin config) and the namespace dir (assets/examplemod -> assets/<id>). Verified end-to-end: renamed copy compiles, the .nbt still loads, the ponder code reference matches the renamed file, and no examplemod/example_ references remain in src. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_015ZSumy7MfmiKehkGd3Y79r
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
./gradlew renameModrenamed Java code and the mixin config, but left theassets/examplemodfolder andexample_ponder.nbtwith their template names,and never rewrote the lang JSON contents. So after renaming:
<id>_ponder.nbtwhile the file was stillexample_ponder.nbt(scene broken),assets/examplemodnamespace folder didn't match the new mod id, andlang/default/*.json+de_de.jsonstill hadexamplemod/example_keys.Fix
.json,.mcmeta) alongside Java/config; binary resources (.nbt,.png) are excluded so they're never mangled.example_ponder.nbt → <id>_ponder.nbt, the mixin config) and the namespace directory (assets/examplemod → assets/<id>, plusdata/if present).Verification
Ran
renameMod --name "Sick Mod"on a throwaway copy:assets/examplemod/ → assets/sickmod/,example_ponder.nbt → sickmod_ponder.nbt.nbtstill loads ([5,2,5], palette intact)addStoryBoard("sickmod_ponder", …)matches the fileexamplemod/example_leftovers insrc/gradlew compileJava→ BUILD SUCCESSFUL)Kept in lockstep with the equivalent fix in
create-addon-cli.🤖 Generated with Claude Code
https://claude.ai/code/session_015ZSumy7MfmiKehkGd3Y79r