feat(dkim): publish DKIM as a CNAME (dns.dkim_cname_domain)#3
Merged
Conversation
Adds an option to let a sending domain use a short CNAME for DKIM instead of pasting the full key. When dns.dkim_cname_domain is set (e.g. dkim1.startuppack.eu), the DKIM record shown in the setup UI and returned by API v2 becomes a CNAME at <selector>._domainkey.<domain> pointing to <dkim_identifier>.<dkim_cname_domain>, which hosts the key TXT on our side. - config_schema: new dns.dkim_cname_domain (optional; TXT mode when unset) - Domain#dkim_cname? / #dkim_cname_value helpers - setup.html.haml renders a CNAME instruction when enabled - API v2 domain serialize exposes dkim_cname + dkim_cname_value - verification unchanged: check_dkim TXT lookup follows the CNAME to the key Verified end-to-end: CNAME -> hosted key TXT, dns_check returns dkim=OK. Closes #2 Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #2 — DKIM via CNAME.
When
dns.dkim_cname_domainis set (e.g.dkim1.startuppack.eu), a sending domain uses a short CNAME at<selector>._domainkey.<domain>→<dkim_identifier>.<dkim_cname_domain>instead of pasting the raw key; the key TXT is hosted on our side. Verification is unchanged (the TXT lookup follows the CNAME).dns.dkim_cname_domainconfig (optional; TXT mode when unset)Domain#dkim_cname?/#dkim_cname_valuedns_checkreturnsdkim=OK.Closes #2