Declare tenacity + document retry policy - #236
Open
nerualauren wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small housekeeping follow-ups to the retry-hardening work (#235).
1. Declare tenacity in requirements
embedding_utilsimports tenacity but it was never declared inrequirements.txt. Same latent-break class as the SDK-9 pinecone bug: works today only because tenacity is transitively present, would break a clean install. Pinned>=8.0.0(floor where all the imported names exist).2. Add CLAUDE.md documenting the retry policy
Records the policy the #235 consolidation established, so the next contributor doesn't re-fragment it:
common/retry.py:with_retrywith_pinecone_retryPlus a note to grep for existing variants before adding a new util (parsimony pass per change).
Needs a one-line
.gitignorenegation (!CLAUDE.md) since the repo ignores*.md, mirroring the existing!requirements.txt.🤖 Generated with Claude Code