Conversation
Adds pnpm overrides (in pnpm-workspace.yaml, the location read by pnpm 11) to bump vulnerable transitive Docusaurus dependencies to patched versions: - shell-quote -> 1.8.4 (critical: newline escaping GHSA, command injection) - serialize-javascript -> 7.0.5 (high RCE + DoS) - lodash -> 4.18.1 (high code injection via _.template + prototype pollution) - joi -> 18.2.1 (uncaught RangeError DoS) - ajv -> 8.20.0, js-yaml -> 4.1.1, yaml -> 1.10.3, ws -> 8.21.0, uuid -> 11.1.1, qs -> 6.15.2 Range-scoped selectors keep other-major consumers untouched (js-yaml 3.x, ajv 6.x, ws 7.x unchanged). pnpm audit now reports 0 vulnerabilities. `pnpm build` succeeds and `vitest` 32/32 pass. Co-Authored-By: Claude Opus 4.8 <[email protected]>
| postman-code-generators: false | ||
| overrides: | ||
| ajv@>=7.0.0-alpha.0 <8.18.0: ^8.18.0 | ||
| joi@<18.2.1: ^18.2.1 |
There was a problem hiding this comment.
WARNING: The Joi override installs a Node 20-only package
package.json still declares support for Node >=18.0, but [email protected] declares engines: {node: '>= 20'} in the updated lockfile. Anyone installing this project on Node 18 with strict engine checks enabled will fail dependency installation, and without strict checks Docusaurus will run against a transitive version outside the declared Node support. Either raise the project engine to Node 20 or choose a patched Joi version that supports Node 18.
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge OverviewThis PR updates the Sui public endpoint documentation from JSON-RPC to GraphQL and adds pnpm overrides/lockfile updates to resolve vulnerable transitive Docusaurus dependencies.
Issue Details (click to expand)WARNING
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Files Reviewed (4 files)
Reviewed by gpt-5.5-2026-04-23 · 273,447 tokens |
Resumen
Resuelve las vulnerabilidades de
pnpm audit(13 → 0) medianteoverrides, sin cambios en las dependencias declaradas. Todas eran transitivas del árbol de Docusaurus.Cambios de seguridad
Se añaden
overridesenpnpm-workspace.yaml(la ubicación que lee pnpm 11; el campopnpmdepackage.jsonya no se lee):shell-quoteserialize-javascriptlodash_.template+ prototype pollution)joiajvjs-yamlyamlwsuuidqsLos selectores son por rango, de modo que los consumidores de otros majors quedan intactos (
js-yaml3.x,ajv6.x,ws7.x sin tocar).Verificación
pnpm audit→ 0 vulnerabilidades.pnpm build(docusaurus) → SUCCESS (los warnings de "broken anchors" son pre-existentes, idénticos a la base).pnpm smoke:test(vitest) → 32/32 OK, incluidos los guards que vigilan el major de Docusaurus.Nota
Como
developya iba por delante demain, este PR incluye también un commit previo no relacionado con seguridad:chore: update sui json-rpc to graphql(tocadocs/public-nodes/public-endpoints.md).🤖 Generated with Claude Code