Skip to content

Improve <embed-code> tag parsing#30

Merged
Vladyslav-Kuksiuk merged 8 commits into
masterfrom
improve-error-messages
May 14, 2026
Merged

Improve <embed-code> tag parsing#30
Vladyslav-Kuksiuk merged 8 commits into
masterfrom
improve-error-messages

Conversation

@Vladyslav-Kuksiuk
Copy link
Copy Markdown
Collaborator

@Vladyslav-Kuksiuk Vladyslav-Kuksiuk commented May 13, 2026

This PR:

  • Fixes multiline attributes parsing for the <embed-code> tag.
    Previously, the multiline tag without additional spaces could not be parsed correctly, now it works:
    <embed-code
    file="org/example/Hello.java"
    start="public class Hello"
    end="System.out.println" />
    ```java
    ```
    
  • Improves related error messages, for example:
    image
    instead of:
    index out of range [-1]
    
  • Improves work with file/folder paths.

@Vladyslav-Kuksiuk Vladyslav-Kuksiuk self-assigned this May 13, 2026
@Vladyslav-Kuksiuk Vladyslav-Kuksiuk marked this pull request as ready for review May 13, 2026 10:51
Copy link
Copy Markdown
Collaborator

@dmytro-kashcheiev dmytro-kashcheiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vladyslav-Kuksiuk Vladyslav-Kuksiuk merged commit 671e40a into master May 14, 2026
3 checks passed
@Vladyslav-Kuksiuk Vladyslav-Kuksiuk deleted the improve-error-messages branch May 14, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants