Prevent redirect loops and chains when renaming pages - #1442
Open
jeroenson wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renaming a page from A to B and later back to A currently leaves two rewrite rules that point at each other (A to B and B to A). Anything hitting the old URL then bounces between the two. We found over 20k of these loop pairs in one of our production databases. Renaming a page twice (A to B, then B to C) leaves a chain, so old links need two redirects to arrive.
This moves the bookkeeping to
RewriteRule.record, which removes rules that redirect away from the new path, points existing rules directly at the final path, and skips blank old paths.Page#rewrite_rulenow just delegates to it.Added tests for the new behavior.