Skip to content

NotificationProtocolDatabaseLocation creation #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Christian-B wants to merge 1 commit into
base: master
Choose a base branch
from
Open

NotificationProtocolDatabaseLocation creation #478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions spinnman/messages/eieio/command_messages/notification_protocol_db_location.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,14 +59,3 @@ def bytestring(self) -> bytes:
if self._database_path is not None:
data += self._database_path
return data

@staticmethod
def from_bytestring(
command_header: EIEIOCommandHeader, data: bytes,
offset: int) -> 'NotificationProtocolDatabaseLocation':
database_path = None
if len(data) - offset > 0:
raise Exception(
"https://github.com/SpiNNakerManchester/SpiNNMan/issues/424")
# database_path = data[offset:]
return NotificationProtocolDatabaseLocation(database_path)
3 changes: 1 addition & 2 deletions spinnman/messages/eieio/create_eieio_command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@ def read_eieio_command_message(
command_number = command_header.command

if command_number == EIEIO_COMMAND_IDS.DATABASE.value:
return NotificationProtocolDatabaseLocation.from_bytestring(
command_header, data, offset + 2)
return NotificationProtocolDatabaseLocation()

@rowleya rowleya Jul 2, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't that miss the content of the message?

@rowleya rowleya Jul 2, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you are claiming that the message is always empty... doesn't that fail in tests then since the tests will need to read the database at some point?

# Fill in buffer area with padding
elif command_number == EIEIO_COMMAND_IDS.EVENT_PADDING.value:
return PaddingRequest()
Expand Down
Loading