Skip to content

better error is username missing #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Christian-B wants to merge 2 commits into
base: master
Choose a base branch
from
Open

better error is username missing #476

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36299ea
better error is username missing
Christian-B Jul 2, 2026
3cab401
typing_extensions import Never
Christian-B Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 24 additions & 4 deletions spinnman/spalloc/spalloc_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@

from packaging.version import Version
import requests
from typing_extensions import TypeAlias
from typing_extensions import Never, TypeAlias
from websocket import WebSocket # type: ignore

from spinn_utilities.abstract_base import AbstractBase, abstractmethod
Expand Down Expand Up @@ -160,9 +160,12 @@ def __init__(
if password is None:
password = os.getenv("SPALLOC_PASSWORD", None)

self.__session: Optional[Session] = Session(
service_url, username, password, bearer_token)
obj = self.__session.renew()
try:
self.__session: Optional[Session] = Session(
service_url, username, password, bearer_token)
obj = self.__session.renew()
except SpallocException as ex:
self._session_error(service_url, ex, username, password)
v = cast(JsonObject, obj["version"])
self.version = Version(
f"{v['major-version']}.{v['minor-version']}.{v['revision']}")
Expand All @@ -174,6 +177,23 @@ def __init__(
self.__nmpi_user = nmpi_user
logger.info("established session to {} for {}", service_url, username)

def _session_error(
self, service_url: str, exception: SpallocException,
username: Optional[str], password: Optional[str]) -> Never:
message = f"Unable to connect to {service_url}. "
if username is None:
if password is None:
message += ("Username and password missing. "
"Please add to url or set ENV SPALLOC_USER "
"and SPALLOC_PASSWORD.")
else:
message += ("Username missing. "
"Please add to url or set ENV SPALLOC_USER.")
elif password is None:
message += ("Password missing. "
"Please add to url or set ENV SPALLOC_PASSWORD.")
raise SpallocException(message) from exception

def get_job(self, job_id: str) -> SpallocJob:
"""
Get a job by its job id.
Expand Down
Loading